Skip to content

Fixup cache key for projects#425

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
shapeblue:fixup-client-cache-key
Mar 21, 2025
Merged

Fixup cache key for projects#425
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
shapeblue:fixup-client-cache-key

Conversation

@vishesh92
Copy link
Member

@vishesh92 vishesh92 commented Mar 20, 2025

Issue #, if available:

Description of changes:

This pull request includes changes to the pkg/cloud/client.go file to improve the client caching mechanism by incorporating the project identifier into the cache key generation.

Improvements to client caching:

  • pkg/cloud/client.go: Modified the generateClientCacheKey function to include the project parameter, ensuring that the cache key is unique per project.
  • pkg/cloud/client.go: Updated the NewClientFromConf function to pass the project parameter to the generateClientCacheKey function.

Testing performed:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@vishesh92 vishesh92 added this to the v0.6 milestone Mar 20, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vishesh92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2025
@netlify
Copy link

netlify bot commented Mar 20, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name Link
🔨 Latest commit 3816259
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/67dc5c332eb18a000880da1d
😎 Deploy Preview https://deploy-preview-425--kubernetes-sigs-cluster-api-cloudstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vishesh92
Copy link
Member Author

vishesh92 commented Mar 20, 2025

/run-e2e -c 4.20

@vishesh92 vishesh92 removed the request for review from chrisdoherty4 March 20, 2025 18:19
@blueorangutan
Copy link

blueorangutan commented Mar 20, 2025

@vishesh92 a jenkins job has been kicked to run test with following paramaters:

  • kubernetes version: 1.27.2
  • CloudStack version: 4.20
  • hypervisor: kvm
  • template: ubuntu-2004-kube
  • Kubernetes upgrade from: 1.26.5 to 1.27.2

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.61%. Comparing base (d597e80) to head (3816259).
Report is 75 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
- Coverage   25.66%   25.61%   -0.06%     
==========================================
  Files          59       69      +10     
  Lines        5563     6699    +1136     
==========================================
+ Hits         1428     1716     +288     
- Misses       3996     4824     +828     
- Partials      139      159      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blueorangutan
Copy link

blueorangutan commented Mar 20, 2025

Test Results : (tid-633)
Environment: kvm Rocky8(x3), Advanced Networking with Management Server Rocky8
Kubernetes Version: v1.27.2
Kubernetes Version upgrade from: v1.26.5
Kubernetes Version upgrade to: v1.27.2
CloudStack Version: 4.20
Template: ubuntu-2004-kube
E2E Test Run Logs: https://github.com/blueorangutan/capc-prs/releases/download/capc-pr-ci-cd/capc-e2e-artifacts-pr425-sl-633.zip



Summarizing 6 Failures:
 [FAIL] When testing clusters in a VPC network [It] Should successfully create a cluster in a VPC network
 /root/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.4.8/framework/cluster_helpers.go:144
 [FAIL] When testing node drain timeout [It] A node should be forcefully removed if it cannot be drained in time
 /root/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.4.8/framework/controlplane_helpers.go:116
 [FAIL] When testing app deployment to the workload cluster [TC1][PR-Blocking] [It] Should be able to download an HTML from the app deployed to the workload cluster
 /jenkins/workspace/capc-e2e-new/test/e2e/deploy_app.go:105
 [FAIL] with two clusters [It] should successfully add and remove a second cluster without breaking the first cluster
 /root/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.4.8/framework/cluster_helpers.go:144
 [FAIL] When testing affinity group [It] Should have host affinity group when affinity is pro
 /jenkins/workspace/capc-e2e-new/test/e2e/common.go:359
 [TIMEDOUT] When testing multiple CPs in a shared network with kubevip [It] Should successfully create a cluster with multiple CPs in a shared network
 /jenkins/workspace/capc-e2e-new/test/e2e/shared_network_kubevip.go:59

Ran 30 of 32 Specs in 10796.692 seconds
FAIL! - Suite Timeout Elapsed -- 24 Passed | 6 Failed | 0 Pending | 2 Skipped
--- FAIL: TestE2E (10796.69s)
FAIL

@blueorangutan
Copy link

blueorangutan commented Mar 21, 2025

Test Results : (tid-635)
Environment: kvm Rocky8(x3), Advanced Networking with Management Server Rocky8
Kubernetes Version: v1.31.6
Kubernetes Version upgrade from: v1.30.10
Kubernetes Version upgrade to: v1.31.6
CloudStack Version: 4.20
Template: ubuntu-2404-kube
E2E Test Run Logs: https://github.com/blueorangutan/capc-prs/releases/download/capc-pr-ci-cd/capc-e2e-artifacts-pr425-sl-635.zip



Summarizing 2 Failures:
 [FAIL] When the specified resource does not exist When starting with a healthy cluster [It] Should fail to upgrade control plane machine due to insufficient compute resources
 /jenkins/workspace/capc-e2e-new/test/e2e/invalid_resource.go:253
 [FAIL] When testing clusters in a VPC network [It] Should successfully create a cluster in a VPC network
 /root/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.4.8/framework/cluster_helpers.go:144

Ran 29 of 32 Specs in 8613.250 seconds
FAIL! -- 27 Passed | 2 Failed | 0 Pending | 3 Skipped
--- FAIL: TestE2E (8613.25s)
FAIL

@weizhouapache
Copy link
Collaborator

weizhouapache commented Mar 21, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit 16d5e02 into kubernetes-sigs:main Mar 21, 2025
10 checks passed
@vishesh92 vishesh92 deleted the fixup-client-cache-key branch March 21, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr Awaiting requested review from yadvr

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

Assignees

@weizhouapache weizhouapache

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v0.6

Development

Successfully merging this pull request may close these issues.

5 participants

@vishesh92 @k8s-ci-robot @blueorangutan @codecov-commenter @weizhouapache